[cpp-qt-client] pass QString by const reference instead of by value

[MartinDelille]

This PR change the signal signature.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh ./bin/configs/*.yaml
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @muttleyxd

[wing328]

Thanks for the PR.

This PR change the signal signature.

so is it a breaking change?

[MartinDelille]

I would say it is not. Indeed, when trying to connect a signal to a slot with a different signature, it still works at least in the test I made.

I have two alternative in mind:

• rename the signal to break the compilation (replacing the EFull suffix by ErrorFull)
• add a new signal with another name and the new signature and deprecate the other.

What do you think about it ?

[wing328]

add a new signal with another name and the new signature and deprecate the other.

I prefer this approach

[MartinDelille]

@muttleyxd @jimschubert @wing328 any feedback ?

[wing328]

restarted failed CI jobs for cpp-qt-client but no luck.

can you please take a look when you've time?

[MartinDelille]

@wing328 The error is quite strange since I am not using jurplel/install-qt-action v4...

I tried to add a name to disambiguate.

[wing328]

please resolve the merge conflicts when you've time.

[MartinDelille]

@wing328 Sorry I missed the notification. I fixed the Qt installation on Windows.

[MartinDelille]

@wing328 any chance to get this merged on the next release ?

[MartinDelille]

up

[wing328]

Let me review and test again this weekend sorry for the delay

[wing328]

thanks again for the PR, which has been merged.

sorry for the delay getting it merged.