Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Java model with instantiated lists #1683

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Dec 16, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For https://stackoverflow.com/q/53756667/677735

cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@wing328 wing328 changed the title ix java instantiated lists Improve Java model with instantiated lists Dec 16, 2018
@wing328 wing328 added this to the 4.0.0 milestone Dec 16, 2018
@wing328 wing328 merged commit b6a2398 into master Dec 17, 2018
@wing328 wing328 deleted the fix_java_default_list branch December 17, 2018 06:42
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@maloef
Copy link

maloef commented Oct 2, 2019

This works in version 4.0.0 and 4.1.0, but it no longer works in version 4.1.1 and 4.1.2: there lists are instantiated as null again.

@jmini
Copy link
Member

jmini commented Oct 16, 2019

there lists are instantiated as null again.

Which is the correct behavior IMO, see #1861 to continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants