Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin] ktor JSON serialization handling #16843

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

kalinjul
Copy link
Contributor

@kalinjul kalinjul commented Oct 17, 2023

#12966 introduced a bug (#14044) where ktor does not perform json serializing at all in requests.
The Content-Type header is simply not set so content negotiation does not step in.

#14045 might also be a solution for this, but it seems to be stalled for some reason (too many changes?), so i created this minimal PR to fix the issue.

This commit fixes the issue for kotlin (ktor) multiplatform and ktor-jvm. Tested with multiplatform.

@jimschubert: Could you review? CI should work, just some download timeouts...

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Oct 18, 2023

cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@wing328 wing328 added this to the 7.1.0 milestone Oct 18, 2023
@wing328 wing328 merged commit f35b132 into OpenAPITools:master Nov 8, 2023
56 checks passed
@wing328
Copy link
Member

wing328 commented Nov 8, 2023

thanks for the fix, which has been merged.

@wing328 wing328 changed the title [Kotlin] fix(#14044): ktor JSON serialization handling [Kotlin] ktor JSON serialization handling Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants