Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Add multiple file upload support #16956

Merged
merged 3 commits into from Nov 1, 2023
Merged

[Go] Add multiple file upload support #16956

merged 3 commits into from Nov 1, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 1, 2023

  • Add Go Echo api client github workflow
  • Add multiple file upload support (no compilation errors)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)

@wing328 wing328 changed the title Add Go Echo api client github workflow Add Go Echo API client Github workflow Nov 1, 2023
@wing328 wing328 added this to the 7.1.0 milestone Nov 1, 2023
@wing328 wing328 changed the title Add Go Echo API client Github workflow [Go] Add multi file upload support Nov 1, 2023
@wing328 wing328 marked this pull request as ready for review November 1, 2023 02:34
@wing328 wing328 changed the title [Go] Add multi file upload support [Go] Add multiple file upload support Nov 1, 2023
@wing328 wing328 merged commit 8d76ab9 into master Nov 1, 2023
19 checks passed
@wing328
Copy link
Member Author

wing328 commented Nov 1, 2023

Just merged it so that #16954 can leverage the Echo API tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant