-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSharp] feat!: add useDateOnly flag #17471
Merged
wing328
merged 37 commits into
OpenAPITools:master
from
Anakael:pr/anakael/csharp-dateonly
Jan 10, 2024
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
2d96a04
feat: DateOnly for client
Anakael a6c7f87
fix: generated doc for csharp
Anakael d0d907d
doc: fix generators README for csharp
Anakael d95ed71
add DateOnly option for aspnet
Anakael 04c2e1c
refactor: update csharp docs
Anakael 176000a
refactor: fix typo
Anakael 79e9272
finish
Anakael 336f446
finish
Anakael 62c3bdc
finish
Anakael ca48306
Merge branch 'master' of https://github.com/OpenAPITools/openapi-gene…
Anakael 86e19a7
regenerate
Anakael 8cb0da6
rebuild and regenerate
Anakael cb9e68e
fix build error
Anakael 4ad27e6
finish
Anakael cdba6a4
revert path
Anakael a3e43c0
regenerate
Anakael 01e3b06
remove exceed samples
Anakael 1b34d02
regenerate
Anakael d17a802
add DateOnly to nullable
Anakael 824b1b6
remove obsolete file from list
Anakael e74b6b1
update test files list
Anakael 9a51577
remove obsolete sample build
Anakael 11040f1
revert manual tests
Anakael 10eb60a
revert samples to master and regenerate
Anakael 6728b91
remove new samples
Anakael e4c16da
remove eol
Anakael 868c8cb
remove eol
Anakael cb69358
add new specs
Anakael f9693d6
try fix test
Anakael 2c5119c
update tests
Anakael e5c7e1e
update files
Anakael 5d0cfdb
remove eol
Anakael b8f524b
revert
Anakael c462bae
remove eol
Anakael 14f2fe1
regenerate
Anakael 267293a
add net6+ support to aspnetcore
Anakael b5ee7bf
add jobs
Anakael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
bin/configs/csharp-generichost-net7.0-useDateTimeForDate.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# for csharp generichost | ||
generatorName: csharp | ||
outputDir: samples/client/petstore/csharp/OpenAPIClient-generichost-net7.0-useDateTimeForDate | ||
inputSpec: modules/openapi-generator/src/test/resources/3_0/csharp/dates-api.yaml | ||
library: generichost | ||
templateDir: modules/openapi-generator/src/main/resources/csharp | ||
additionalProperties: | ||
packageGuid: '{2E60EF87-DB0B-4D01-A36E-F5E90F7EC757}' | ||
useDateTimeForDate: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# for .net standard | ||
generatorName: csharp | ||
outputDir: samples/client/petstore/csharp/OpenAPIClient-net7.0-useDateTimeForDate | ||
inputSpec: modules/openapi-generator/src/test/resources/3_0/csharp/dates-api.yaml | ||
templateDir: modules/openapi-generator/src/main/resources/csharp | ||
additionalProperties: | ||
packageGuid: '{D0A67E81-4061-48EB-B4B8-C73BDF8B2D95}' | ||
targetFramework: net7.0 | ||
useDateTimeForDate: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in https://github.com/OpenAPITools/openapi-generator/tree/master/.github/workflows, there are workflows for dotnet.
can you please add the new sample folders to these workflow so that CI will tests to make sure these samples compile without issues moving forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I've also noticed that netcore-latest samples not captured in
on
section's regexes. Is it intended or mistake?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely a mistake. can you please file another PR to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.