Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-spring] fix BigDecimal default value failed to compile #17956

Merged

Conversation

irasychan
Copy link
Contributor

Fixes #14584

When a property is of type number and has a default value, the Kotlin Spring generator will generate code like val bar: java.math.BigDecimal? = 0, which will not compile, since an Int cannot be assigned to BigDecimal. This PR fixes that bug.

This PR applies changes from #12213 to kotlin-client to kotlin-spring

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier

@irasychan irasychan force-pushed the kotlin_spring-bigdecimal_default branch from 0669f31 to 8095d4b Compare February 28, 2024 15:59
@irasychan irasychan marked this pull request as draft March 1, 2024 17:04
@irasychan irasychan marked this pull request as ready for review March 1, 2024 17:04
@irasychan
Copy link
Contributor Author

irasychan commented Mar 8, 2024

As the reviewer assigned, @jimschubert, is no longer active in this repository, according to his resume site and his Github activity over the past 2 years.

@wing328 @4brunu @stefankoppier
Would you be able to help with this PR?

@4brunu
Copy link
Contributor

4brunu commented Mar 8, 2024

Looks good to me 👍

@4brunu 4brunu merged commit 62d0e3a into OpenAPITools:master Mar 8, 2024
28 checks passed
@wing328 wing328 added this to the 7.4.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [kotlin-spring] Bigdecimal generation with default value is not working
3 participants