Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] fix anyof, oneof mixed primitive object parse error #17986

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 28, 2024

based on #16706 with resolved merge conflicts

cc
@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

ForgeRubenAguilar and others added 3 commits October 12, 2023 21:03
… object, and array types when deserializing

 Add bug openapi spec

Remove generated files

Add test endpoints

Generate base on spec

Remove issue spec as it is moved into sample test spec

Add back in number and int

Round trip anyOf/oneOf serialization tests

Generate classes with int/num types

Do through converter instead of object ctor

Regen models

Use convert methods

Regen models

Test data

Add enum

Remove enums

Regenned models
@wing328 wing328 changed the title Forge ruben aguilar csharp/anyof oneof mixed primitive object parse error Csharp/anyof oneof mixed primitive object parse error Feb 28, 2024
@wing328 wing328 added this to the 7.4.0 milestone Feb 28, 2024
@wing328 wing328 marked this pull request as ready for review February 29, 2024 08:04
@wing328 wing328 changed the title Csharp/anyof oneof mixed primitive object parse error [C#] fix anyof, oneof mixed primitive object parse error Feb 29, 2024
@wing328 wing328 merged commit d4e1050 into master Feb 29, 2024
43 checks passed
@wing328 wing328 deleted the ForgeRubenAguilar-csharp/anyof-oneof-mixed-primitive-object-parse-error branch February 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants