Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][apache-httpclient] Use EntityUtils#toString instead of Scanner for deserialization #17998

Conversation

AB-xdev
Copy link
Contributor

@AB-xdev AB-xdev commented Feb 29, 2024

Fixes #16818

EntityUtils#toString automatically selects the correct encoding based on the received request.
Scanner currently uses the JVM default encoding, which doesn't always work.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Further notes

  • When building on Windows many files are generated with \ instead of / (had to revert the changes manually) - This is behavior is already present on the current master branch

@AB-xdev AB-xdev changed the title [JAVA][apache-httpclient] Use EntityUtils#toString instead of Scanner for deserialization [Java][apache-httpclient] Use EntityUtils#toString instead of Scanner for deserialization Feb 29, 2024
@wing328 wing328 added this to the 7.4.0 milestone Mar 1, 2024
@wing328
Copy link
Member

wing328 commented Mar 1, 2024

please update the samples so that the CI can verify the change: https://github.com/OpenAPITools/openapi-generator/actions/runs/8095529271/job/22155733266?pr=17998

…canner``

``EntityUtils#toString`` automatically selects the correct encoding based on the received request.
Scanner currently uses the JVM default encoding, which doesn't always work.
@AB-xdev AB-xdev force-pushed the java-apache-httpclient-deser-fix-encoding branch from 422bf8b to 844661b Compare March 1, 2024 07:18
@AB-xdev
Copy link
Contributor Author

AB-xdev commented Mar 1, 2024

Oh, I overlooked this...
Anyway I updated it accordingly, now it should work :)

@wing328
Copy link
Member

wing328 commented Mar 2, 2024

lgtm. thanks for the fix.

@wing328 wing328 merged commit 009fda5 into OpenAPITools:master Mar 2, 2024
69 checks passed
@AB-xdev AB-xdev deleted the java-apache-httpclient-deser-fix-encoding branch March 4, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants