Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputSpec should not be mandatory when inputSpecRootDirectory is set #18000

Conversation

andreas-wirth
Copy link
Contributor

Fix #16955 : inputSpec should not be mandatory if inputSpecRootDirectory is set
(@borsch @wing328 )

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Mar 1, 2024

@andreas-wirth thanks for the PR. can you please add a test?

@andreas-wirth
Copy link
Contributor Author

@wing328 Added some unit tests, let me know if they fit your expectations

@MelleD
Copy link
Contributor

MelleD commented Mar 5, 2024

Looks good so far :)

@andreas-wirth
Copy link
Contributor Author

Any Feedback @wing328 ?

@wing328 wing328 changed the title Fix #16955 inputSpec should not be mandatory when inputSpecRootDirectory is set inputSpec should not be mandatory when inputSpecRootDirectory is set Mar 9, 2024
@wing328 wing328 added this to the 7.4.0 milestone Mar 9, 2024
@wing328 wing328 merged commit c87ad56 into OpenAPITools:master Mar 9, 2024
15 checks passed
@wing328
Copy link
Member

wing328 commented Mar 9, 2024

thanks for the PR, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Maven plugin incorrectly marks inputSpec as a required field
3 participants