Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAXRS-SPEC] no @Valid annotation on simple fields #18302

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

martin-mfg
Copy link
Contributor

based on #14435 by @anatoliy-balakirev

fix #14432

  • The change in beanValidation.mustache is still the same as in 14432: Do not add @Valid to Java types in "jaxrs-spec" generator #14435.
  • The change in pojo.mustache had to be adapted a bit, because the file has changed on the master branch in the meantime.
    I also added a small whitespace change to improve the generated code's style a bit. It's still not great though.
  • I also added a new unit test in JavaJAXRSSpecServerCodegenTest.java

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented Apr 6, 2024

It's still not great though.

we recommend users to run linter e.g. spotless to auto format the code based on their preference.

@wing328
Copy link
Member

wing328 commented Apr 6, 2024

lgtm. thanks for the fix.

have a nice weekend

@wing328 wing328 merged commit b11005b into OpenAPITools:master Apr 6, 2024
31 checks passed
@wing328 wing328 added this to the 7.5.0 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [JAVA] [JAXRS-SPEC] jarxrs-spec generators adds @Valid annotation to standard java types / enums
2 participants