Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-client] Update Gradle and dependencies #18571

Merged
merged 15 commits into from
May 5, 2024

Conversation

stefankoppier
Copy link
Contributor

@stefankoppier stefankoppier commented May 5, 2024

Updated versions of dependencies and Gradle itself. Resolves #18570. By effect, Java 8 is no longer supported to run Gradle. At least Java 11 must be used.

Does not resolve, but relates to #17890

To update the versions, some other changes had to be made:

  1. jvm-volley can't be upgraded to the newest Gradle because of imcompatibility issues, which require an upgrade to Java 17. This may be unwanted.
  2. The workflow for the kotlin clients no longer has a pinned Gradle version, the version is retrieved from the Gradle wrappers.
  3. Moved kotlin-spring-cloud sample from clients to server.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@stefankoppier stefankoppier marked this pull request as draft May 5, 2024 08:53
@stefankoppier stefankoppier marked this pull request as ready for review May 5, 2024 11:33
@wing328
Copy link
Member

wing328 commented May 5, 2024

lgtm. thanks for the PR

@wing328 wing328 merged commit f145b89 into OpenAPITools:master May 5, 2024
75 checks passed
@wing328 wing328 added this to the 7.6.0 milestone May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kotlin-client] Upgrade versions of dependencies and Gradle
2 participants