Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOTLIN] Kotlinx serialization, use first party retrofit converter factory #18656

Conversation

larst-ingka
Copy link
Contributor

Requirement #18593

What has changed:
Switched out the retrofit converter factory used for kotlinx_serialization in the kotlin generator with the new first party converter.

  • Dependency changed com.jakewharton.retrofit:retrofit2-kotlinx-serialization-converter -> com.squareup.retrofit2:converter-kotlinx-serialization in modules/openapi-generator/src/main/resources/kotlin-client/build.gradle.mustache
  • Import changed com.jakewharton.retrofit2.converter.kotlinx.serialization.asConverterFactory -> retrofit2.converter.kotlinx.serialization.asConverterFactory in modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-retrofit2/infrastructure/ApiClient.kt.mustache

Why was it changed:

Given that no further development is to be expected on the deprecated repository, and the fact that the repo was moved to a first party converter with no code changes between.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Technical committee mentions

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@4brunu
Copy link
Contributor

4brunu commented May 13, 2024

Looks good to me 👍

@4brunu 4brunu merged commit 2a15270 into OpenAPITools:master May 13, 2024
57 checks passed
@larst-ingka larst-ingka deleted the req_18593/kotlin_serialization_use_first_party_converter branch May 13, 2024 11:52
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
…ctory (OpenAPITools#18656)

* Switch the jakewharton converter factory for the first party one

* Run all samples generation
@wing328 wing328 added this to the 7.6.0 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants