Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA-SPRING] Avoid broken code due to duplicate rendering of @Deprecated annotation with generateBuilders=true #18917

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jun 13, 2024

Closes #12804

Merge after #18921

… as the regression test builds upon the features introduced into the test stack there, namely inner class assertions.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Philzen Philzen force-pushed the bugfix/12804-fix-duplicated-deprecated-annotations branch from aac2514 to 66f13f4 Compare June 13, 2024 22:34
@Philzen Philzen changed the title Implement InnerClassAssert for easy inner class testing [JAVA-SPRING] Avoid broken code due to duplicate rendering of @Deprecated annotation with generateBuilders=true Jun 13, 2024
@Philzen Philzen marked this pull request as ready for review June 13, 2024 22:51
@Philzen
Copy link
Contributor Author

Philzen commented Jun 13, 2024

@wing328 should we maybe add the generateBuilders option to one of the spring samples as an additional safeguard against regressions?

Ah i didn't regenerate the samples, there are actually two that cover this. So in that case they should be added to the build test matrix.

Done now via e46fb6e

@Philzen Philzen force-pushed the bugfix/12804-fix-duplicated-deprecated-annotations branch 2 times, most recently from 74cd599 to fcf0091 Compare June 14, 2024 01:20
@Philzen Philzen force-pushed the bugfix/12804-fix-duplicated-deprecated-annotations branch 4 times, most recently from 728477b to 8770092 Compare June 15, 2024 23:18
@Philzen Philzen force-pushed the bugfix/12804-fix-duplicated-deprecated-annotations branch from 8770092 to ebf46a5 Compare June 16, 2024 02:09
@Philzen
Copy link
Contributor Author

Philzen commented Jun 16, 2024

@wing328 Rebased now :)

@wing328
Copy link
Member

wing328 commented Jun 16, 2024

thanks. will take a look later today

have a nice weekend

@wing328
Copy link
Member

wing328 commented Jun 16, 2024

lgtm. thanks for the fix

@wing328 wing328 merged commit 6f9ad31 into OpenAPITools:master Jun 16, 2024
60 checks passed
@wing328 wing328 added this to the 7.7.0 milestone Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Not generating @Deprecated annotations
2 participants