-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA-SPRING] Avoid broken code due to duplicate rendering of @Deprecated
annotation with generateBuilders=true
#18917
Merged
wing328
merged 6 commits into
OpenAPITools:master
from
Philzen:bugfix/12804-fix-duplicated-deprecated-annotations
Jun 16, 2024
Merged
[JAVA-SPRING] Avoid broken code due to duplicate rendering of @Deprecated
annotation with generateBuilders=true
#18917
wing328
merged 6 commits into
OpenAPITools:master
from
Philzen:bugfix/12804-fix-duplicated-deprecated-annotations
Jun 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aac2514
to
66f13f4
Compare
@Deprecated
annotation with generateBuilders=true
5 tasks
74cd599
to
fcf0091
Compare
728477b
to
8770092
Compare
Serves as an additional regression check for OpenAPITools#12804
8770092
to
ebf46a5
Compare
@wing328 Rebased now :) |
thanks. will take a look later today have a nice weekend |
lgtm. thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12804
Merge after #18921
… as the regression test builds upon the features introduced into the test stack there, namely inner class assertions.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)