Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Update okhttp version to the latest #1897

Merged
merged 10 commits into from
Jan 16, 2019
Merged

[Java] Update okhttp version to the latest #1897

merged 10 commits into from
Jan 16, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jan 12, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update okhttp version from 2.x to 3.x

@wing328 wing328 added this to the 4.0.0 milestone Jan 12, 2019
@auto-labeler
Copy link

auto-labeler bot commented Jan 12, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328
Copy link
Member Author

wing328 commented Jan 12, 2019

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Please review the change (Java Petstore client) to see if it looks good to you.

Then I'll plot those changes back to the mustache templates.

UPDATE: mustache templates have been updated accordingly.

@wing328 wing328 removed the WIP Work in Progress label Jan 13, 2019
@wing328 wing328 changed the title [WIP][Java] Update okhttp version to the latest [Java] Update okhttp version to the latest Jan 13, 2019
Copy link
Contributor

@jeff9finger jeff9finger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly perused changes. Was not able to deep dive, but LGTM

@wing328
Copy link
Member Author

wing328 commented Jan 16, 2019

@jeff9finger thanks for reviewing the change. I added some tests to test different operations in Petstore and the result is good.

@wing328 wing328 merged commit 1676aef into master Jan 16, 2019
@wing328 wing328 deleted the update-okhttp branch January 16, 2019 12:30
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* update okhttp to latest version

* update templates to use okhttp3

* update java samples

* fix tests

* update tests under CI/samples.ci

* add tests to java client

* fix bin script to restore test files

* fix debugging

* add more tests and minor fixes

* update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants