Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thread unsafe statusCode and responseHeaders instance variables from apache http ApiClient #19054

Merged

Conversation

aaronforest-wf
Copy link
Contributor

@aaronforest-wf aaronforest-wf commented Jul 2, 2024

fix #11852

This fixes the same problem as swagger-api/swagger-codegen#1435, but for the apache http client. It is implemented differently here to maintain backwards compatibility.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@aaronforest-wf
Copy link
Contributor Author

Ready for review

Java Apache Http template creators:
@harrywhite4 @andrevegas

Java technical committee:
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

public Map<String, List<String>> getResponseHeaders() {
return responseHeaders;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make this PR backward compatible, can we keep these changes and mark these methods as deprecated instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've re-added these methods. The implementations are a bit more complex now, but they should be thread safe.

@wing328 wing328 merged commit 8ab3bb4 into OpenAPITools:master Jul 8, 2024
74 checks passed
@wing328
Copy link
Member

wing328 commented Jul 8, 2024

thanks for the PR, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Make apache-httpclient generated ApiClient thread-safe.
2 participants