[Python] handle nullable parameters with None added to allowed_values #2034
Conversation
rienafairefr
changed the title
| @@ -108,6 +108,9 @@ class {{classname}}(object): | |||
| {{#isEnum}} | |||
| {{#isContainer}} | |||
| allowed_values = [{{#allowableValues}}{{#values}}{{#items.isString}}"{{/items.isString}}{{{this}}}{{#items.isString}}"{{/items.isString}}{{^-last}}, {{/-last}}{{/values}}{{/allowableValues}}] # noqa: E501 | |||
There was a problem hiding this comment.
Why not instead, in each allowed_values definitions add something like?
allowed_values = [{{#isNullable}}None, {{/isNullable}}{{#allowableValues}}{{#values}}{{#items.isString}}"{{/items.isString}}{{{this}}}{{#items.isString}}"{{/items.isString}}{{^-last}}, {{/-last}}{{/values}}{{/allowableValues}}] # noqa: E501
There was a problem hiding this comment.
Yeah, would probably be cleaner. I wasn't sure, feared to add too much commas or something :-)
It created a bunch of changes because it runs: |
We only added python scripts to the ensure up-to-date script recenlty so don't worry about those additional changes. Please commit those changes and we'll review accordingly. |
rienafairefr
force-pushed
the
required-nullable-enum
branch
from
240caf9
to
f6b5e5f
Compare
rienafairefr
force-pushed
the
required-nullable-enum
branch
from
f6b5e5f
to
16563f5
Compare
|
@spacether @wing328 PR updated, thanks for the review guys |
…OpenAPITools#2034) * handle nullable parameters with None added to allowed_values * update samples * spec for testing enum with null/nullable
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.@wing328 @taxpon @frol @mbohlool @cbornet @kenjones-cisco
Description of the PR
I think this fixes #1997, if a parameter is nullable, then
Noneshould be an allowed value.I ran `./bin/saples/python-petstore-all.sh' it created a bunch of changes that don't seem related, not sure why.