Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin Server Ktor] upgrade to stable version (1.1.3) #2333

Merged
merged 5 commits into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@karismann
Copy link
Contributor

karismann commented Mar 8, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @jimschubert (2017/09), @dr4ke616 (2018/08)

Description of the PR

fix #716

karismann added some commits Mar 10, 2019

@wing328

This comment has been minimized.

Copy link
Member

wing328 commented Mar 12, 2019

@jimschubert when you've time, I wonder if you can review this PR. Thanks.

@jimschubert
Copy link
Member

jimschubert left a comment

New sample runs and Docker container in generated code still builds as well.

@wing328 wing328 merged commit f2ff473 into OpenAPITools:master Mar 14, 2019

4 checks passed

Shippable Run 6532 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@karismann karismann deleted the karismann:kotlin-server-ktor-uprade branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.