New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin Server Ktor] upgrade to stable version (1.1.3) #2333
Merged
wing328
merged 5 commits into
OpenAPITools:master
from
karismann:kotlin-server-ktor-uprade
Mar 14, 2019
Merged
[Kotlin Server Ktor] upgrade to stable version (1.1.3) #2333
wing328
merged 5 commits into
OpenAPITools:master
from
karismann:kotlin-server-ktor-uprade
Mar 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Mar 8, 2019
modules/openapi-generator/src/main/resources/kotlin-server/libraries/ktor/build.gradle.mustache
Outdated
Show resolved
Hide resolved
wing328
reviewed
Mar 8, 2019
modules/openapi-generator/src/main/resources/kotlin-server/libraries/ktor/build.gradle.mustache
Outdated
Show resolved
Hide resolved
wing328
reviewed
Mar 8, 2019
...les/openapi-generator/src/main/resources/kotlin-server/libraries/ktor/ApiKeyAuth.kt.mustache
Outdated
Show resolved
Hide resolved
fix indentation
wing328
reviewed
Mar 10, 2019
modules/openapi-generator/src/main/resources/kotlin-server/libraries/ktor/AppMain.kt.mustache
Outdated
Show resolved
Hide resolved
@jimschubert when you've time, I wonder if you can review this PR. Thanks. |
jimschubert
approved these changes
Mar 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New sample runs and Docker container in generated code still builds as well.
modules/openapi-generator/src/main/resources/kotlin-server/libraries/ktor/Paths.kt.mustache
Show resolved
Hide resolved
fix compilation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
,./bin/security/{LANG}-petstore.sh
and./bin/openapi3/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,. Default:3.4.x
,4.0.x
master
.@jimschubert (2017/09), @dr4ke616 (2018/08)
Description of the PR
fix #716