Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin client] Improve JSON parser #2981

Merged
merged 2 commits into from
May 24, 2019

Conversation

karismann
Copy link
Contributor

@karismann karismann commented May 23, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @Zomzog (2019/04)

Description of the PR

Copy link
Member

@jimschubert jimschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The typeMapping from LocalDateTime to LocalDate may be seen as a breaking change, but I'd consider this a bug. I thought we'd fixed this LocalDate issue in the Kotlin base, but I looked and it was only applied in KotlinSpringServerCodegen.

If users find this change breaks existing clients, they may regenerate with --type-mappings date=java.time.LocalDateTime for the previous behavior.

@jimschubert
Copy link
Member

@karismann this looks good. Is it ready to merge?

@karismann
Copy link
Contributor Author

@jimschubert yes, thanks for the review!

@jimschubert jimschubert merged commit c4bf658 into OpenAPITools:master May 24, 2019
@karismann karismann deleted the kotlin-json-parser branch May 25, 2019 05:34
@wing328 wing328 added this to the 4.0.1 milestone May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants