Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] configurable limit of simultaneous connections (python/asyncio) #3200

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

tomplus
Copy link
Member

@tomplus tomplus commented Jun 22, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

A current generated asyncio client limits number of simultaneous connections to 4 and this values is not configurable by the configuration object. In PR I use value from configuration and set default to 100 (it's default value recommended by the aiohttp library).

Thanks for reviewing and merging it :)

CC: @wing328 @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @Jyhess (2019/01)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 5b9283b into OpenAPITools:master Jun 25, 2019
@wing328 wing328 changed the title feat: configurable limit of simultaneous connections (python/asyncio) [Python] configurable limit of simultaneous connections (python/asyncio) Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants