Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release table in the project's README #3221

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jun 26, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Remove the tab

@wing328 wing328 mentioned this pull request Jun 26, 2019
4 tasks
Copy link
Member

@jimschubert jimschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, since I think this line needs to be updated manually anyway (for the date).

Looks like it would also work to move the <!-- /RELEASE_VERSION --> to inside the table delimiter if the first column, like after the link.

@wing328
Copy link
Member Author

wing328 commented Jun 26, 2019

The CI errors are not related to this change

@wing328 wing328 merged commit f41cd23 into master Jun 26, 2019
@wing328 wing328 deleted the wing328-patch-release-table branch June 26, 2019 14:09
@wing328 wing328 added this to the 4.0.3 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants