Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] updated example in doc(.md) file #3429

Merged
merged 2 commits into from
Jul 24, 2019
Merged

[R] updated example in doc(.md) file #3429

merged 2 commits into from
Jul 24, 2019

Conversation

Ramanth
Copy link
Contributor

@Ramanth Ramanth commented Jul 23, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

updated the documentaiton, api_doc.mustache file with inclusion of example as per latest exception handling changes.

@wing328, please look into this as well.

@Ramanth Ramanth changed the title fix(r): updated doc(.md) files fix(r): updated example in doc(.md) file Jul 23, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would suggest creating a new branch for the change moving forward.

@wing328 wing328 merged commit a4b1c26 into OpenAPITools:master Jul 24, 2019
@wing328 wing328 added this to the 4.1.0 milestone Jul 24, 2019
@wing328 wing328 changed the title fix(r): updated example in doc(.md) file [R] updated example in doc(.md) file Jul 24, 2019
@wing328
Copy link
Member

wing328 commented Aug 10, 2019

@Ramanth thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants