Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Log some things in model/url utils once #5233

Merged
merged 2 commits into from Feb 9, 2020

Conversation

jimschubert
Copy link
Member

Some operational messages are iterated multiple times during some generations and should only be logged once.

This uses the cache I recently added to debounce some log messages. By default the messages once'd here will only display a most once per 2 seconds, and is configurable (see OnceLogger for details).

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@OpenAPITools/generator-core-team fyi

@auto-labeler
Copy link

auto-labeler bot commented Feb 7, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jimschubert jimschubert added this to the 4.3.0 milestone Feb 7, 2020
* master:
  comment out python flask test
  comment out PythonAiohttpServer test in travis
@jimschubert jimschubert merged commit 2aa8a6d into OpenAPITools:master Feb 9, 2020
@jimschubert jimschubert deleted the more-once-logging branch February 9, 2020 05:19
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant