[templates] Update templates vendor ext standards #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luate Haskell Client changes
|
cc @OpenAPITools/generator-core-team |
|
This PR is work toward #4976. Once merged, and master is integrated into the 5.x branch, we can remove the "old" format vendor extensions. |
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
* [templates] Update to vendor extension standard keys * Fix missed value in Java template, also implements=>x-implements. Evaluate Haskell Client changes * Fix missing accept/content-type update for vendor extension format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the templates for a number of languages to follow the lower-kebab with
x-prefix for vendor extensions as we've defined in our contributing documentation (and thex-prefix is required by OAI specification).This fixes an issue I introduced in #5192 in which Haskell client is using additionalProperties as a sort of vendorExtension, and I'd worked to update all properties and found that those additionalProperties were not prefixed in templates with
vendorExtensions.. It's possible that additionalProperties makes sense for these properties--I didn't dig into it.The changes in this PR are simply moving to our convention. There should be no effect on template consumers/extenders as the old format vendor extensions still exist and there is a warning that the format has been deprecated in 4.3.0.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.