[PHP] Fix additionalProperties annotation in models. #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest version of generator
|
I dont understand - is there anything wrong with pr, or bug in "ci/bitrise/4a2b10a819d12b67/pr" check script? |
|
The bitrise error has nothing to do with this PR. |
ackintosh
approved these changes
Feb 19, 2020
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
* Fix additionaVariables in php-symfony model * Fix additionaVariables in php-symfony model (second try, tested)
|
@reznikartem thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When create object with additionalProperties, it`s annotated as
@Type("array<datatype>")And it`s cause wrong array conversion from associative array to simple list.
Now it fixed, and annotation looks like
@Type("array<string, datatype>")PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).I`m run php-symfony-petstore.sh, but nothing was changed. I suppose, additionalProperties not used in petstore models
[+] File the PR against the correct branch:
master,4.3.x,5.0.x. Default:master.[+] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)