Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'x-generate-alias-as-model' extension to allow enabling generating alias as model per-schema #6937

Merged
merged 1 commit into from Jul 23, 2020

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Jul 14, 2020

This allows turning on the generate-alias-as-model option per schema with an x-generate-alias-as-model extension.

Since this is not a language-specific change, but rather a core change, I'm not sure who to CC... So hopefully CCing @wing328 and @jimschubert is ok.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Member

wing328 commented Jul 22, 2020

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Jul 22, 2020

LGTM. Will merge tomorrow if no further feedback from the core team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants