Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php][bug] Fix offsetGet in model generic to return offset rather than bool|null #7571

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

alsma
Copy link
Contributor

@alsma alsma commented Oct 1, 2020

Reverted previous behavior for offsetGet method

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)

Reverted previous behavior for offsetGet method
@jimschubert jimschubert added this to the 5.0.0 milestone Oct 2, 2020
@jimschubert jimschubert changed the title Fix offsetGet bug in PHP model generic template [php][bug] Fix offsetGet in model generic to return offset rather than bool|null Oct 2, 2020
@jimschubert
Copy link
Member

Thanks for the bug fix!

Usually I'd wait for template maintainer responses before merge. It's been ~7 years since I last used PHP, but I think the fix here is pretty obvious. If one of the template maintainers has any concerns, please open another issue.

@jimschubert jimschubert merged commit bb4e0c0 into OpenAPITools:master Oct 2, 2020
@alsma alsma deleted the patch-1 branch October 2, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants