Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin][Client] create request config method #8617

Merged

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Feb 4, 2021

Hi,
Currently I have a problem when that in some situations, I need to make a request outside of generated code by OpenAPI.

For example, if I have an endpoint that returns an image, and I want to load that image with an image loader, for example Glide or Picasso, that already handles the caching and scalling part, I need to manually configure the request.

Or if I need to make a network request to create a bearer token in the server API, I need to manually make the request.

In those situations, I need to manually create the url and configure the request.
This this leads to errors especially when updating to a news version of the API.

In order to solve this, I created one extra method that returns the RequestConfig which can be used to get the request info.

This was inspired in the Swift generator.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@4brunu
Copy link
Contributor Author

4brunu commented Feb 8, 2021

Done 👍

@wing328 wing328 added this to the 5.1.0 milestone Feb 9, 2021
@wing328 wing328 merged commit 7a435ac into OpenAPITools:master Feb 9, 2021
@4brunu 4brunu deleted the feature/kotlin-request-config-method branch February 9, 2021 16:17
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@4brunu thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants