Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][JAVA] fix AbstractOpenApiSchema package #8635

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

BenjaminKlatt
Copy link
Contributor

@BenjaminKlatt BenjaminKlatt commented Feb 7, 2021

Fixed package declaration in AbstractOpenApiSchema.mustache template

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas, @sreeshas, @jfiala, @lukoyanov, @cbornet, @jeff9finger, @karismann, @Zomzog, @lwlee2608, @nmuesch

To fix #8583

Fixed package declaration in AbstractOpenApiSchema.mustache template
@wing328 wing328 added this to the 5.0.1 milestone Feb 7, 2021
@wing328 wing328 changed the title FIX #8583 [BUG][JAVA] AbstractOpenApiSchema package [BUG][JAVA] AbstractOpenApiSchema package Feb 7, 2021
@wing328 wing328 changed the title [BUG][JAVA] AbstractOpenApiSchema package [BUG][JAVA] fix AbstractOpenApiSchema package Feb 7, 2021
@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@wing328 wing328 merged commit c5ddf46 into OpenAPITools:master Feb 8, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@BenjaminKlatt thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] AbstractOpenApiSchema package output and declaration missmatch
2 participants