-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift5] escape reserved words #9204
[Swift5] escape reserved words #9204
Conversation
e72b19b
to
a8f8e26
Compare
This is a nice improvement, but this is a breaking change, so we need to create a flag that keep's the old behaviour by default. |
I think this should be the default behavior but I understand that this would introduce a breaking change. Thus, I think it's best to merge this to the |
a8f8e26
to
46944f9
Compare
For this to be merged in the branch 5.2.x it new to have a fallback to the old behaviour. |
46944f9
to
412e26b
Compare
Will the changes from the other PRs be merged to |
Yes, but the version 6.0.x will only be release to the end of the year, or begin of next year. |
412e26b
to
a970a45
Compare
57948f2
to
a9e2528
Compare
@aymanbagabas thanks for the changes. |
samples/client/petstore/swift5/rxswiftLibrary/docs/Model200Response.md
Outdated
Show resolved
Hide resolved
a9e2528
to
3864a34
Compare
@aymanbagabas please resolve the merge conflicts when you've time. |
3864a34
to
502de86
Compare
Resolved |
Swift reserved words should be escaped using backticks `` as the reference explains https://docs.swift.org/swift-book/ReferenceManual/LexicalStructure.html#ID412
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x