Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-slim4] Decouple Slim4 codegen from Slim3 #9208

Merged
merged 1 commit into from
May 24, 2021

Conversation

ybelenko
Copy link
Contributor

@ybelenko ybelenko commented Apr 7, 2021

It was a mistake to extend Slim4 from Slim3 codegen. When I need to fix something in Slim4 I have to overwrite code from Slim3 somehow and it's not always possible. It's even more important that Slim3 codegen shouldn't be touched as soon as it's deprecated long time ago.

Refresh samples didn't change which is main goal of this PR.

Guys, please merge this PR asap, I need to rebase on this all other php-slim4 PRs.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon

It was a mistake to extend Slim4 from Slim3 codegen. When I need to fix
something in Slim4 I have to overwrite code from Slim3 somehow and it's
not always possible. It's even more important that Slim3 codegen shouldn't
be touched as soon as it's deprecated long time ago.
@ybelenko ybelenko added this to In progress in PHP Slim4 Server Generator via automation Apr 7, 2021
@ybelenko ybelenko moved this from In progress to Needs review in PHP Slim4 Server Generator Apr 8, 2021
@ybelenko
Copy link
Contributor Author

@wing328 Could you please look at that when you have time? Since you in the PHP context right now.

@ybelenko
Copy link
Contributor Author

Since @wing328 is really busy and that PR not actually related to PHP, but Java code in general I would subscribe @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented May 24, 2021

LGTM

@wing328 wing328 merged commit 1e92469 into OpenAPITools:master May 24, 2021
PHP Slim4 Server Generator automation moved this from Needs review to Done May 24, 2021
@ybelenko ybelenko deleted the decouple_slim4_from_slim3 branch May 24, 2021 06:31
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
It was a mistake to extend Slim4 from Slim3 codegen. When I need to fix
something in Slim4 I have to overwrite code from Slim3 somehow and it's
not always possible. It's even more important that Slim3 codegen shouldn't
be touched as soon as it's deprecated long time ago.
@wing328 wing328 added this to the 5.2.0 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants