Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin] Make ApiClient in jvm-retrofit2 be able to add additional retrofit Converter.Factory #9316

Conversation

shanselm-ergon
Copy link
Contributor

@shanselm-ergon shanselm-ergon commented Apr 22, 2021

[Kotlin][#7925] Make ApiClient in jvm-retrofit2 be able to add additional retrofit Converter.Factory

The serializer option is not enough, we need an additional Converter.Factory for date serialization in query params (not body).

fixes #7925

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@4brunu
Copy link
Contributor

4brunu commented Apr 22, 2021

Looks good to me 👍

@wing328
Copy link
Member

wing328 commented Apr 22, 2021

Tested locally and the result is good;

> Task :compileKotlin
w: /Users/williamcheng/Code/openapi-generator/samples/client/petstore/kotlin-retrofit2/src/main/kotlin/org/openapitools/client/auth/OAuthOkHttpClient.kt: (42, 72): 'create(MediaType?, String): RequestBody' is deprecated. Moved to extension function. Put the 'content' argument first to fix Java

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.8.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1m 1s
1 actionable task: 1 executed

@wing328
Copy link
Member

wing328 commented Apr 22, 2021

Travis CI failure not related to this change.

@wing328 wing328 merged commit 5468b22 into OpenAPITools:master Apr 22, 2021
@shanselm-ergon shanselm-ergon deleted the kotlin-retrofit2-additional-converter-factory branch April 22, 2021 11:52
@wing328 wing328 changed the title [Kotlin][#7925] Make ApiClient in jvm-retrofit2 be able to add additional retrofit Converter.Factory [Kotlin] Make ApiClient in jvm-retrofit2 be able to add additional retrofit Converter.Factory Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kotlin] Make ApiClient in jvm-retrofit2 be able to add additional retrofit Converter.Factory
3 participants