Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-server-deprecated] minor improvements #9367

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Apr 29, 2021

  • update code comment
  • mark generator as deprecated
  • minor wording change
  • remove samples (not required for deprecated generator)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title [kotlin-server-deprecated] minor improvement [kotlin-server-deprecated] minor improvements Apr 29, 2021
@wing328 wing328 modified the milestones: 5.1.1, 5.2.0 Apr 29, 2021
@wing328 wing328 merged commit 1c1c6b4 into 5.2.x Apr 29, 2021
@wing328 wing328 deleted the kotlin-depreacated-improve branch April 29, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant