-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aspnetcore] Fix incorrect logging messages #9405
Conversation
@@ -592,6 +592,7 @@ private void setModelClassModifier() { | |||
private void setBuildTarget() { | |||
setCliOption(buildTarget); | |||
if ("library".equals(buildTarget.getOptValue())) { | |||
LOGGER.warn("buildTarget is " + buildTarget.getOptValue() + " so changing default isLibrary to true "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
LOGGER.warn("buildTarget is {} so changing default isLibrary to true", buildTarget.getOptValue());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed 4fc83c6
@@ -636,7 +637,7 @@ private String determineTemplateVersion(String frameworkVersion) { | |||
|
|||
private void setUseSwashbuckle() { | |||
if (isLibrary) { | |||
LOGGER.warn("buildTarget is " + buildTarget.getOptValue() + " so changing default isLibrary to false "); | |||
LOGGER.warn("isLibrary is true so changing default useSwashbuckle to false "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: removing the trailing whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed 4fc83c6
cleans up log messages
LGTM |
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x