[C++][Pistache] fix missing default values for string and enum types #9541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current generated codes for the C++ pistache server does not pass the correct default value for strings (and thus enums) to the templates. This PR just fixes that.
That way, non-required enum values are not set to an empty string in the constructor of a model, if a corresponding default value is specified.
yaml example
generated constructor:
Please note that the
someOtherEnum
value still receives an invalid value, since no valid default was defined!NOTE: I did run the generate-samples script, but it did not generate differing files. I suspect that the samples don't have this edge case anywhere.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd