Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Pistache] fix missing default values for string and enum types #9541

Merged

Conversation

JulianGmp
Copy link
Contributor

The current generated codes for the C++ pistache server does not pass the correct default value for strings (and thus enums) to the templates. This PR just fixes that.

That way, non-required enum values are not set to an empty string in the constructor of a model, if a corresponding default value is specified.

yaml example

Pet:
  type: object
  required:
    - someEnum
    - someOtherEnum
    - someString
    - someOtherString
  properties:
    someEnum:
      type: string
      enum: [EnumVal1, EnumVal2, EnumVal3]
      default: EnumVal1
    someOtherEnum:
      type: string
      enum: [OtherEnumVal1, OtherEnumVal2, OtherEnumVal3]
    someString:
      type: string
      default: "hello world"
    someOtherString:
      type: string

generated constructor:

Pet::Pet()
{
    m_SomeEnum = "EnumVal1";
    m_SomeOtherEnum = "";
    m_SomeString = "hello world";
    m_SomeOtherString = "";
}

Please note that the someOtherEnum value still receives an invalid value, since no valid default was defined!

NOTE: I did run the generate-samples script, but it did not generate differing files. I suspect that the samples don't have this edge case anywhere.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

@wing328 wing328 merged commit 7c152da into OpenAPITools:master May 23, 2021
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
@wing328 wing328 added this to the 5.2.0 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants