Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][resttemplate] added localVar prefix to local variable named contentType to prevent naming conflicts #9568

Merged
merged 1 commit into from
May 27, 2021

Conversation

desmese
Copy link
Contributor

@desmese desmese commented May 24, 2021

fix #9565 and fix #9566. This bug solves the naming conflict in both #9565 and #9566. I added the localVar prefix to the local variable named contentType in the api.mustache template in the resttemplate-library. When an API specified a parameter named Content-Type this would cause a naming conflict with the variable named contentType in the api.mustasche in the resttemplate library. #9566 has more information about how to reproduce the bug.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

…i.mustache template in the java resttemplate library

- rerun generate-samples.sh and export_docs_generators.sh
@wing328
Copy link
Member

wing328 commented May 27, 2021

LGTM. I'll regenerate the samples and docs after merging this PR.

@wing328 wing328 added this to the 5.2.0 milestone May 27, 2021
@wing328 wing328 merged commit 4f1d8f4 into OpenAPITools:master May 27, 2021
@wing328 wing328 changed the title - bugfix added localVar prefix to local variable named contentType to prevent naming conflicts [java][resttemplate] added localVar prefix to local variable named contentType to prevent naming conflicts May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants