Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Spring] fix Spring RequestMapping #9900

Merged
merged 4 commits into from
Jul 27, 2021

Conversation

borsch
Copy link
Member

@borsch borsch commented Jul 6, 2021

Rollback changes from PR #7189 because those changes introduce compilation error due to missing HEAD & OPTIONS specific annotation.

Issue #9773

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@borsch
Copy link
Member Author

borsch commented Jul 6, 2021

@mwatel42, @billbarni @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) @wing328

please review

Copy link

@mwatel42 mwatel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mustache files look good to me for both Java and Kotlin

@daberni
Copy link
Contributor

daberni commented Jul 6, 2021

Maybe we could add a sample case so the OPTIONS annotation is validated next time?

@borsch borsch force-pushed the fix-spring-request-mapping branch from 94e8fbb to 4fdf1ee Compare July 21, 2021 15:30
@borsch borsch closed this Jul 21, 2021
@borsch borsch reopened this Jul 21, 2021
@borsch
Copy link
Member Author

borsch commented Jul 22, 2021

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) @wing328

@borsch borsch closed this Jul 25, 2021
@borsch borsch reopened this Jul 25, 2021
@wing328
Copy link
Member

wing328 commented Jul 27, 2021

Tested locally and the result is good. Found an issue with Pageable class and will file another PR to address it.

UPDATE: filed #10045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants