Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to use admin token for release checkout action #648

Merged
merged 1 commit into from
May 2, 2024

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented May 2, 2024

What kind of change does this PR introduce?
This reverts a change that was made earlier, to use the secrets.ADMIN_TOKEN for the release checkout action

Summary
It looks like because the checkout action was carried out with a token, there are issues in further actions when trying to push to the protected main branch.

https://github.com/OpenAdaptAI/OpenAdapt/actions/runs/8910687505/job/24470804634 - semantic release action failed. The only change w.r.t tokens from when the action was passing, is the secrets.ADMIN_TOKEN being passed to the checkout action earlier

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

@abrichr abrichr merged commit 1d80f33 into OpenAdaptAI:main May 2, 2024
1 check passed
R-ohit-B-isht pushed a commit to R-ohit-B-isht/OpenAdapt that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants