Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert user when any exception occurs, via sentry hooks #685

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented May 23, 2024

What kind of change does this PR introduce?
This PR displays an alert ot the user when an unhandled exception occurs.

Summary
When an unhandled exception occurs, an alert box is shown to the user, with a link to join the discord server, or contact openadapt through email.

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?
Raise any exception at any part of the code, for example, the start_recording function in tray.py, and click on the Record option in the tray. You should see a window pop up.

Other information

openadapt/config.py Show resolved Hide resolved
openadapt/config.py Outdated Show resolved Hide resolved
openadapt/config.py Show resolved Hide resolved
Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrichr abrichr merged commit 6492120 into OpenAdaptAI:main Jun 5, 2024
1 check passed
R-ohit-B-isht pushed a commit to R-ohit-B-isht/OpenAdapt that referenced this pull request Jun 21, 2024
…penAdaptAI#685)

* feat: Alert user when any exception occurs, via sentry hooks

* chore: Turn ERROR_REPORTING_BRANCH to a static config variable

---------

Co-authored-by: Richard Abrich <richard.abrich@mldsai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants