-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
So this is going to pull out support for PFC1? I'm finding myself stuck trying to figure out where I'm going to take the legacy hardware. There are a number of design flaws including weak sensors in PFC1 but the cost to retrofit it to be entirely a PFC2 ecosystem I might as well just toss them and build PFC2s. At least the PFC1's have working lights tho. :-) |
We're kind of exploring a couple different configurations to see which method of implementation will provide the most value for us in regards to hardware. Either way, we will probably be heading in a way where anyone with different hardware needs to write a way to interface that with ROS. The contract will be publishing and subscribing to environmental variable topics defined under the |
ffb2d24
to
e30df82
Compare
and only publish when we have data
…erface with real hardware
e30df82
to
f401130
Compare
rosdep install --from-paths src --ignore-src --rosdistro indigo -y -r --os=debian:jessie | ||
|
||
# Source ROS environment | ||
source /opt/ros/indigo/setup.bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct path? You sure it shouldn't be source ~/catkin_ws/devel/setup.bash
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this install script it's the correct one, but it no longer works with this install script so I will rewrite accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll leave it up to @spaghet to merge this if it is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si, es bueno.
Practicing Spanish Rob? ;)
…On Jun 23, 2017 8:49 AM, "Rob Baynes" ***@***.***> wrote:
***@***.**** approved this pull request.
Si, es bueno.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#278 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASauPKJQxCEdF0J8aNvNXUsAZIYq-0SNks5sG7RqgaJpZM4N6al_>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
Summary
This change introduces a way to interface with sensors and actuators directly from the pi. The goal of this is create the option to run the brain without the use of an arduino.
Motivation
Before the bespoke serial messaging protocol, the communication between the raspi and arduino was unreliable. This was a parallel development effort to create a stable system as fast as possible. It was also required for integrating the brain box code into the main software stack. Furthermore, running all code on a single board simplifies the system.
Details
New nodes are added and named with a functional prefix. E.g. sensor_am2315 or actuator_relay. Nodes manage rostopics and event loops. The nodes call a helper module for each device (e.g. am2315 or relay) found in the peripheral directory. It is here where all the code for actually interfacing with the device sits.
This PR interfaces with the following:
Sensors
Actuators:
UI:
Drawbacks
Running timing sensitive code will not be possible from this approach.
Alternatives