Make sure build_sdist requires targets as it is needed for the artifact upload condition #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct upload condition
|
Can we tag this in |
|
Done already! |
|
Great. Thanks! |
|
Well spotted! The condition was only added in #162, so maybe there wasn't an astropy release since then? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #167
The issue was that the artifact upload condition in the sdist job is:
but the sdist job didn't technically require targets so
needs.targets.outputs.upload_to_pypiwasn't set correctly. I don't quite understand why this wasn't an issue before, maybe GitHub got more strict about this, or maybe it is a race condition.This also explains why astropy nightlies were working fine - the anaconda upload condition is separate and doesn't rely on
needs.targets.