New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sunpy 2023 projects #330
Conversation
_projects/2023/sunpy/sunkit_image.md
Outdated
Therefore the aim of this GSoC project is: | ||
|
||
1. Refactor each function to accept and return a sunpy.map.Map instead of a numpy array. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have some additional aims here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. All ideas welcome.
@wafels had some in the meeting as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if all the compensation for solar rotation stuff should be removed from the co-alignment code? Solar rotation in SunPy is now much more mature than it was when the co-alignment code was written. I think if I was doing this now I would perform the solar rotation first and then do the co-alignment. I think a workflow, or a few potential workflows, should be worked out to guide what functionality is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another idea I had was to perform image comparison using different metrics other than cross-correlation - see chapter two of DOI 10.1007/978-1-4471-2458-0.
@nabobalis - could you please rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so let's get this in and iterate in follow-up PRs both on the CI issues and if you need to do any changes to the content.
A start on the sunpy 2023 GSoC Projects.