Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sunpy 2023 projects #330

Merged
merged 3 commits into from Jan 27, 2023
Merged

Add sunpy 2023 projects #330

merged 3 commits into from Jan 27, 2023

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Dec 31, 2022

A start on the sunpy 2023 GSoC Projects.

@nabobalis nabobalis changed the title add sunpy 2023 projects, WIP but good enough add sunpy 2023 projects Dec 31, 2022
@nabobalis nabobalis changed the title add sunpy 2023 projects Add sunpy 2023 projects Dec 31, 2022
gsoc/index.md Outdated Show resolved Hide resolved
Therefore the aim of this GSoC project is:

1. Refactor each function to accept and return a sunpy.map.Map instead of a numpy array.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have some additional aims here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. All ideas welcome.

@wafels had some in the meeting as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if all the compensation for solar rotation stuff should be removed from the co-alignment code? Solar rotation in SunPy is now much more mature than it was when the co-alignment code was written. I think if I was doing this now I would perform the solar rotation first and then do the co-alignment. I think a workflow, or a few potential workflows, should be worked out to guide what functionality is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idea I had was to perform image comparison using different metrics other than cross-correlation - see chapter two of DOI 10.1007/978-1-4471-2458-0.

@bsipocz
Copy link
Member

bsipocz commented Jan 27, 2023

@nabobalis - could you please rebase?

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so let's get this in and iterate in follow-up PRs both on the CI issues and if you need to do any changes to the content.

@bsipocz bsipocz merged commit 8c9815b into OpenAstronomy:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants