Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to mentors on how to add ideas #61

Merged
merged 5 commits into from Feb 8, 2017
Merged

Add instructions to mentors on how to add ideas #61

merged 5 commits into from Feb 8, 2017

Conversation

dpshelio
Copy link
Member

@dpshelio dpshelio commented Feb 4, 2017

It also excludes the readme and template from being rendered by Jekyll

@eteq @taldcroft @Cadair - let me know if this readme looks ok

It also excludes the readme and template from being rendered by jekyll
@Cadair
Copy link
Member

Cadair commented Feb 4, 2017

I would maybe put a TLDR quick start at the top of the readme for the more experienced folks that just need a quick intro. Maybe a list of steps like "make dir, copy template, PR".


Please, if you have any issue with the following steps contact your org admin or
ask in the multi-client real-time
[chat platform we have](http://openastronomy.org/contact.html) (Thanks @Cadair!).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to create this page with the info @Cadair sent on the mailing list. This page is also needed for the application

dpshelio and others added 2 commits February 4, 2017 19:39
professionalism, student interaction, etc...
Copy link
Contributor

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cadair @dpshelio - OK, left some comments. Note that while reading this I also left some comments about the template that I think are confusing people (and thereby preventing e.g. me from submitting project ideas). Would be good to have @Cadair look and see if any of those will mess up the neat and fancy web site machinery.

One other thing: maybe the _projects/README.md file should actually be /IDEAS.md? It's really not at all obvious that I should look in _projects to find this, because the leading underscore makes it seem like it's a data directory or something rather than a place to actually look for content.

the [template file](./_template.md) according to your idea, save it under
`_projects/YYYY/sub-org/` with a meaningful filename and do a Pull-request.

## What to I need to have an idea?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to->do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done.

All you need now is to put it in a plain text file following
the [template file](./_template.md) (you may click in raw to see how it looks).

The file is composed in two parts (separated by a `---`), the top is like a yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"like a"? I'm not sure what you mean by that. I'm also not sure it's that important for a mentor to know that? Maybe just drop the part after the first comma in this sentence?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the top uses yaml formatting, the rest markdown. But sure, now it's simpler.

part (_e.g._, the top level starts with a 4 level title: `####`).


## How do I do so it appears online?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How->What

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

## How do I do so it appears online?

Are you familiar with git/github? If you are not contact us and share the above
file with us, we will take care to put it in place.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say who "us" is - give a specific email address or something like that. Remember that if someone doesn't find the information necessary to submit in idea in this document, they probably won't submit anything... Ridiculously low barrier to entry is the goal!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email added.

Are you familiar with git/github? If you are not contact us and share the above
file with us, we will take care to put it in place.
If, in the other hand, you are feel confident with github: go ahead, fork this
repository, create a subdirectory for your sub-organisation (if that doesn't
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be very specific. For example, "find the subdirectory for your sub-organisation and the year of the project (for example, if you are submitting an astropy project, go to /_projects/2017/astropy). If your organization does not exist, create it following the form of one of the other organizations."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks!

issues:
- https://github.com/astropy/astropy/issue/4444
- https://github.com/astropy/astropy/issue/5555
mentors:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "possible mentors"? We never know until the project starts, of course.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that should be the point of contact at the moment for the student writing the application.

desc: This is the first idea for astropy
# add a description of your project
requirements:
- The proposal has to contain a clear concept.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this section means. Requirements for the student? Like "knows some astronomy"? Or requirements for the project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the student - Changed accordingly.

@@ -0,0 +1,50 @@
---
name: Example Astropy
desc: This is the first idea for astropy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this, and the "description" below? I suggest removing this and having the name be the only "description" in this section

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a one line description - it appears on the box together with the title. Added a description in the comment.

initiatives:
- GSOC
- SOCIS
tags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? I think without structure people will be confused by what they're supposed to do with it. I suggest leaving it off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a description,

tags:
- python
collaborating_projects:
- astropy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, why is this here? Isn't the file going to already be in the astropy section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the directory structure is just to keep the things in order. This is to be able to separate them by sub-orgs and enables cross-collaborative project.

@eteq
Copy link
Contributor

eteq commented Feb 4, 2017

Oh, and I didn't note it in the comments above, but I suggest there be just one template rather than one per project directory. But in the project directory maybe we can place a README that points back to this file?

@dpshelio
Copy link
Member Author

dpshelio commented Feb 5, 2017

Oh, and I didn't note it in the comments above, but I suggest there be just one template rather than one per project directory. But in the project directory maybe we can place a README that points back to this file?

The "templates" on the projects are just so they appear on the website, so you can have an idea of how they look. They will be removed once we get a single real idea. Adding random files in different directories need to then be added to the exclude list in the config file.

One other thing: maybe the _projects/README.md file should actually be /IDEAS.md? It's really not at all obvious that I should look in _projects to find this, because the leading underscore makes it seem like it's a data directory or something rather than a place to actually look for content.

The leading underscore is a jekyll thing (if I'm not wrong). We can move the _projects/README.md above, but I'm just worried that the top directory gets too full and this page is not only for GSOC.

@dpshelio dpshelio mentioned this pull request Feb 5, 2017
@Cadair Cadair merged commit c6fc17b into OpenAstronomy:master Feb 8, 2017
@Cadair
Copy link
Member

Cadair commented Feb 8, 2017

further refinements can happen in subsequent PRs

@dpshelio dpshelio deleted the help_ideas branch February 11, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants