Fixing smaller issues and moving a few things around #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plz fix #4154 as well |
|
?
|
You fixed it. Magic. |
|
Impressed by myself sometimes that running the command is enough |
|
Note that on the reports, we run integration test on those, so if a key is not provided (which they aren't in the CI), they should not fail. Can you confirm this by changing your api key to something invalid or deleting from the env file? |
JerBouma
changed the title
dd, update SDK paths
|
@jmaslek I did it mom, deleted .env and this is the result. This PR should now be ready for review.
|
jmaslek
approved these changes
Feb 8, 2023
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the following things:
arktradestoscreener. It has no business being instocks/fa.ddas this menu is integrated instocks/fafilingscommand back in but moved it tostocks/discsince it has no business being on the home page ofstocksfixing [Bug] Filings function refactored into/stocks/FAmenu. They are not the same functions and serve totally different purposes. #4162.heet_nameincall_shrs. Fixed that too./ 100. See this source: https://www.federalreserve.gov/releases/h15/ (same as EconDB which we get data from) for the 10 year and then tryeconomy/treasury --export xlsx. Previously this gave you 353%, a bit high don't you think? Fixes [IMPROVE] Treasury rates fromeconomy/treasuryare wrongly exported to Excel #4082ignore_tz=True. Now fixed which fixes [Bug] Economy Menu - Plotting function not plotting two things #4020 and [Bug] Error when charting multiple country indices #4022.overview --source YahooFinancewhich fixes [Bug] stocks/fa/info - Error: Yahoo has again changed data format, yfinance now unsure which key(s) is for decryption #4044.