-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing smaller issues and moving a few things around #4155
Conversation
plz fix #4154 as well |
Impressed by myself sometimes that running the command is enough |
Note that on the reports, we run integration test on those, so if a key is not provided (which they aren't in the CI), they should not fail. Can you confirm this by changing your api key to something invalid or deleting from the env file? |
dd
, update SDK paths
@jmaslek I did it mom, deleted .env and this is the result. This PR should now be ready for review. |
🥳 |
This changes the following things:
arktrades
toscreener
. It has no business being instocks/fa
.dd
as this menu is integrated instocks/fa
filings
command back in but moved it tostocks/disc
since it has no business being on the home page ofstocks
fixing [Bug] Filings function refactored into/stocks/FA
menu. They are not the same functions and serve totally different purposes. #4162.heet_name
incall_shrs
. Fixed that too./ 100
. See this source: https://www.federalreserve.gov/releases/h15/ (same as EconDB which we get data from) for the 10 year and then tryeconomy/treasury --export xlsx
. Previously this gave you 353%, a bit high don't you think? Fixes [IMPROVE] Treasury rates fromeconomy/treasury
are wrongly exported to Excel #4082ignore_tz=True
. Now fixed which fixes [Bug] Economy Menu - Plotting function not plotting two things #4020 and [Bug] Error when charting multiple country indices #4022.overview --source YahooFinance
which fixes [Bug] stocks/fa/info - Error: Yahoo has again changed data format, yfinance now unsure which key(s) is for decryption #4044.