Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --std argument in bbands command #4866

Merged
merged 9 commits into from
May 2, 2023

Conversation

northern-64bit
Copy link
Contributor

Description

Closing #4863.

Makes the --std parameter actually influence the output and fixes the handling of float inputs.

How has this been tested?

Running the command with float inputs and assuring that the result varies.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@northern-64bit northern-64bit added the bug Fix bug label Apr 22, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 22, 2023
@northern-64bit northern-64bit linked an issue Apr 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 42.44% and project coverage change: -0.21 ⚠️

Comparison is base (df9a154) 58.29% compared to head (081abaa) 58.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4866      +/-   ##
===========================================
- Coverage    58.29%   58.08%   -0.21%     
===========================================
  Files          588      588              
  Lines        53666    53687      +21     
===========================================
- Hits         31283    31184      -99     
- Misses       22383    22503     +120     
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...bb_terminal/core/sdk/models/portfolio_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
... and 24 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the parameter accepts the float value, the legend does not reflect that choice between 1 and 1.5

Screenshot 2023-04-23 at 7 17 05 PM

@deeleeramone
Copy link
Contributor

Now it's awkwardly on top. Isn't it strange how each trace isn't defined on a proper legend that you can toggle on/off?

Screenshot 2023-04-30 at 7 44 58 PM

Screenshot 2023-04-30 at 7 48 44 PM

@northern-64bit
Copy link
Contributor Author

Now it's awkwardly on top. Isn't it strange how each trace isn't defined on a proper legend that you can toggle on/off?

I created an issue (#4932) regarding the overlap, which already has a pr linked to it now. Shall we merge this and then adjust possibly adjust it and add a legend for each trace after #4941? The pr fixes the --std argument and the missing legend for each trace is an overarching thing for the whole TA menu, so it should be its own issue.

@deeleeramone
Copy link
Contributor

I created an issue (#4932) regarding the overlap, which already has a pr linked to it now. Shall we merge this and then adjust possibly adjust it and add a legend for each trace after #4941?

Excellent!

Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-05-01 at 5 50 25 PM

@jmaslek jmaslek added this pull request to the merge queue May 2, 2023
Merged via the queue into OpenBB-finance:develop with commit 7a19424 May 2, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] stocks/ta/bbands --std argument does not work.
3 participants