Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature / Refactor Interactive Charts to React #4941

Merged
merged 103 commits into from
May 11, 2023

Conversation

tehcoderer
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XL Extra Large feature label May 1, 2023
@tehcoderer tehcoderer linked an issue May 1, 2023 that may be closed by this pull request
@jose-donato
Copy link
Contributor

🍝

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 59.20% and project coverage change: -0.25 ⚠️

Comparison is base (df9a154) 58.29% compared to head (53ba749) 58.04%.

❗ Current head 53ba749 differs from pull request most recent head 04e6dfa. Consider uploading reports for the commit 04e6dfa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4941      +/-   ##
===========================================
- Coverage    58.29%   58.04%   -0.25%     
===========================================
  Files          588      588              
  Lines        53666    53809     +143     
===========================================
- Hits         31283    31236      -47     
- Misses       22383    22573     +190     
Impacted Files Coverage Δ
openbb_terminal/core/plots/plotly_helper.py 73.09% <ø> (ø)
...al/core/plots/plotly_ta/plugins/momentum_plugin.py 27.55% <ø> (ø)
...nal/core/plots/plotly_ta/plugins/overlap_plugin.py 43.75% <ø> (ø)
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
openbb_terminal/core/plots/plotly_ta/ta_class.py 74.77% <0.00%> (ø)
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 37.50% <ø> (+0.57%) ⬆️
... and 43 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@the-praxs
Copy link
Contributor

Are we moving to React from Plotly?

@jose-donato
Copy link
Contributor

Are we moving to React from Plotly?

still using plotly

@tehcoderer
Copy link
Contributor Author

tehcoderer commented May 1, 2023

Are we moving to React from Plotly?

@the-praxs still using Plotly just refactored chart frontend from JS to react

@the-praxs
Copy link
Contributor

@tehcoderer @jose-donato gotcha!

@jmaslek
Copy link
Collaborator

jmaslek commented May 1, 2023

Still no file popup when export on mac :(

@jmaslek jmaslek enabled auto-merge May 11, 2023 17:28
@jmaslek jmaslek added this pull request to the merge queue May 11, 2023
Merged via the queue into OpenBB-finance:develop with commit 979930b May 11, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
6 participants