-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improve posthog logs #4951
Merged
jmaslek
merged 35 commits into
OpenBB-finance:develop
from
hjoaquim:feature/improve-posthog-lgos
May 12, 2023
Merged
Feature/improve posthog logs #4951
jmaslek
merged 35 commits into
OpenBB-finance:develop
from
hjoaquim:feature/improve-posthog-lgos
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also if i follow this route Load up terminal in guest Run a few commands Login Run a few more commands
|
Nice catch! I think last commits solves both comments thank you, @andrewkenreich |
…enBBTerminal into feature/improve-posthog-lgos
…penBBTerminal into feature/improve-posthog-lgos
reviewpad
bot
added
feat S
Small T-Shirt size Feature
and removed
feat XS
Extra small feature
labels
May 8, 2023
reviewpad
bot
added
feat XS
Extra small feature
and removed
feat S
Small T-Shirt size Feature
labels
May 8, 2023
…enBBTerminal into feature/improve-posthog-lgos
reviewpad
bot
added
feat S
Small T-Shirt size Feature
and removed
feat XS
Extra small feature
labels
May 10, 2023
Pls only merge this PR after #4941 |
jmaslek
approved these changes
May 11, 2023
Merged
via the queue into
OpenBB-finance:develop
with commit May 12, 2023
addd4f7
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the following:
improving handling of logging handlers --> changing the responsibility to the
SystemModel
insteadadding the commithash to the system so it gets logged
don't send logs to S3 if posthog is an active handler
branch name on the posthog logs
Fixes #4303 by clearly identify the branch name for each event (posthog) and each session (file/s3).