Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve posthog logs #4951

Merged
merged 35 commits into from
May 12, 2023

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented May 2, 2023

This PR proposes the following:

Fixes #4303 by clearly identify the branch name for each event (posthog) and each session (file/s3).

@reviewpad reviewpad bot added the feat XS Extra small feature label May 2, 2023
@hjoaquim hjoaquim changed the title Feature/improve posthog lgos Feature/improve posthog logs May 2, 2023
@andrewkenreich
Copy link
Contributor

image

We can update this so it shows something

@andrewkenreich
Copy link
Contributor

andrewkenreich commented May 4, 2023

also if i follow this route

Load up terminal in guest

Run a few commands

Login

Run a few more commands

  • I dont get alliased anymore - im guessing we dont update the user after in a certain spot?

@hjoaquim
Copy link
Contributor Author

hjoaquim commented May 5, 2023

Nice catch! I think last commits solves both comments thank you, @andrewkenreich

@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels May 8, 2023
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat S Small T-Shirt size Feature labels May 8, 2023
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels May 10, 2023
@hjoaquim
Copy link
Contributor Author

Pls only merge this PR after #4941

@jmaslek jmaslek enabled auto-merge May 11, 2023 18:19
@jmaslek jmaslek added this pull request to the merge queue May 12, 2023
Merged via the queue into OpenBB-finance:develop with commit addd4f7 May 12, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] logs should only be collected on main branch
3 participants