Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.0 Release #48

Merged
merged 137 commits into from
May 31, 2023
Merged

v0.1.0 Release #48

merged 137 commits into from
May 31, 2023

Conversation

OpenBagTwo
Copy link
Owner

@OpenBagTwo OpenBagTwo commented May 27, 2023

Summary

Release staging for EnderChest v0.1.0

List of Changes

Tech Debt and Other Concerns

To Do

Validation Performed

This release will not be cut until I've transitioned my existing EnderChest installations across my various machines and eaten my own dogfood for at least a little bit.

For #47 specifically:

  • Running enderchest -h shows the verb as gather minecraft (it was almost going to be gather minecrafts 😬 )
  • Running enderchest gather -h shows the main help message
  • Running enderchest gather instances (from a folder that actually has an "instances" folder) spits out:
    usage: enderchest gather minecraft [-h] [--root ROOT_FLAG] [--verbose] [--quiet] [--official | --mmc] [root] search_paths [search_paths ...]
    enderchest gather minecraft: error: the following arguments are required: search_paths

PR Type

  • This PR introduces a breaking change (will
    require a bump in the minor version)
  • The changes is high urgency and necessitates a hotfix or patch release
    (will require rebasing off of release)
  • This is a release (staging) PR (maintainer use only)

Checklist:

  • I have read the contributor's guide
  • I have run mkdocs serve locally and ensured that all API docs and
    changes I have made to the static pages are rendering correctly, with all links
    working
  • All tech debt concerns have been resolved, documented as issues, or otherwise
    accepted
  • I agree to license my contribution to this project under
    the GNU Public License v3

OpenBagTwo and others added 30 commits October 29, 2022 21:16
Ready to try something that's no sphinx
fetch-depth of 0 means "grab all commits and branches"
which is not the default
Surprised I hadn't added these before.

Also, as someone who went through _a lot of trial and error_ creating issue and PR templates by hand back in the day, I **absolutely love** that [github now has an interface](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository) for generating these
(a lot of this will be coming back)
for everything but the minecraft versioning
And I owe a cookie to the person who taught me about for-else
rbarrois/python-semanticversion#147 notwithstanding

This commit implements #27
@OpenBagTwo
Copy link
Owner Author

Dogfooding update: I've now got two computers all set up with EnderChests, encompassing 29 shulker boxes (and no, I definitely don't have 29 instances, even spread across both machines).

Is this an improvement over the old system? I mean, #23 aside, it's definitely a lot more difficult to tell where everything is and to guard against duplicates. But I've captured that point in #50, and what I've already observed is that bootstrapping a new instance (which was incredibly painful with v0.0.4) will be much easier now. Especially when using something like PrismLauncher which can fetch any mods that you're missing. Even updating mods (#24) is kinda nice because you just do an enderchest place -k, and you can see right away all the mods that need to be moved upstream just by looking at the list of broken links.

@OpenBagTwo
Copy link
Owner Author

Okay, it's release time. Let's see if I can do this correctly. I believe the order of ops is:

  1. Merge
  2. Kill docs build
  3. Cut release off release
  4. Rerun docs build (aha! It's all coming back to me now...)
  5. Rebase dev off of release

Gonna document the process here so I can find it the next time.

@OpenBagTwo
Copy link
Owner Author

Oh wait. Pause. Minecraft 1.20-rc1 just dropped. Let's make sure it doesn't break anything.

@OpenBagTwo
Copy link
Owner Author

Well my mod appears to be broken, but it linked just fine (along with the world and resourcepacks, etc.)

@OpenBagTwo OpenBagTwo merged commit cbdff81 into release May 31, 2023
10 checks passed
@OpenBagTwo OpenBagTwo deleted the staging-0.1.0 branch May 31, 2023 16:12
@OpenBagTwo
Copy link
Owner Author

OpenBagTwo commented May 31, 2023

Yeah, so release-docs-push failed:

error: version 'release' already exists

So I'll have to do this manually for now. Odd that dev never had this problem...

@OpenBagTwo
Copy link
Owner Author

Ah, bless you, mike:

If [version] already exists, this command will also update all of the pre-existing aliases for it. Normally, if an alias specified on the command line is already associated with another version, this will return an error. If you do want to move an alias from another version to this version (e.g. when releasing a new version and updating the latest alias to point to this new version), you can pass -u/--update-aliases to allow this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant