Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform Additional Shulker Box Validation (WIP) #50

Open
OpenBagTwo opened this issue May 27, 2023 · 0 comments
Open

Perform Additional Shulker Box Validation (WIP) #50

OpenBagTwo opened this issue May 27, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@OpenBagTwo
Copy link
Owner

OpenBagTwo commented May 27, 2023

spun off from #34

GIVEN Steve has EnderChest installed and set up on his machine
WHEN he runs any linking or syncing operation (place, open, close, etc.)

THEN his shulker box and EnderChest configurations are automatically validated, with either errors being raised or warnings being thrown with automatic corrections taking place
AND this happens before the operation actually takes place

SO that he doesn't end up with a setup that's messed up
AND so his EnderChest is tidy and easy to maintain

Notes

This is a work in progress. Things to check:

  • Steve should be prompted to delete empty folders in shulker boxes unless they're part of a specific ignore list (prompt will ask if the folder should be added to the ignore list, and there will also be a prompt option for "just delete 'em and quit asking")
  • Links getting into a shulker box's link folder pointing to another shulker box should emit an "are you sure?" (with per box, per folder memory so that Steve isn't asked every time). There might be valid reasons to do this, but I can't think of them.
    • 🦆 wait, I totally can: managing nesting sets of mods in a way that will completely avoid the question of "wait, did I already specify this mod?" But then again, I don't think that will work right now based on how links are relative.
  • Link folders that will overwrite non-empty folders are currently caught when you try to place them. This should migrate to checking before the place, and especially should simulate the place to check that another (prior) shulker isn't going to make that folder non-empty
    • This would be a good opportunity to ask "Hey, should we just move the contents of this folder into the shulker box?"
  • Check for duplicate files that are literal duplicates (same filename, same hash) and offer to delete one and symlink the other to it
@OpenBagTwo OpenBagTwo added the enhancement New feature or request label May 27, 2023
@OpenBagTwo OpenBagTwo added this to the v0.2 milestone May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant