Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Bugfixes: Error propagation, migrations version fix, no gofmtcheck for pb's #1019

Merged
merged 3 commits into from
Jul 13, 2018

Conversation

tyler-smith
Copy link
Member

Simple bugfixes

  • tx.Commit() returns and error so this should be propagated
  • Migrations only use a single bytes for writing the repo version to disk (in ASCII). This means migrations don't work after 9. This should allow a full int
  • There is no need to check gofmt'ing on protobuf generated Go code because it shouldn't be changed even if it violates gofmt rules.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 31.422% when pulling c6c9f06 on TS_bugfixes into 2cf88a7 on master.

Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@tyler-smith tyler-smith merged commit 7e5acb3 into master Jul 13, 2018
@tyler-smith tyler-smith deleted the TS_bugfixes branch July 18, 2018 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants