Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Allow mobile node to be restarted #1656

Merged
merged 8 commits into from
Aug 8, 2019
Merged

Allow mobile node to be restarted #1656

merged 8 commits into from
Aug 8, 2019

Conversation

cpacia
Copy link
Member

@cpacia cpacia commented Jul 16, 2019 •
edited
Loading

This PR adds a restart method to the mobile node.

@coveralls
Copy link

coveralls commented Jul 16, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 38.11% when pulling 7648f75 on mobile-stop into 9d5e4e3 on master.

placer14
placer14 suggested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove diff for qa/__init__.py from PR. There are some changes to consider before being ready to merge.

api/gateway.go Show resolved Hide resolved
mobile/cmd/main.go Show resolved Hide resolved
mobile/node.go Outdated Show resolved Hide resolved
mobile/node.go Outdated Show resolved Hide resolved
mobile/node.go Outdated Show resolved Hide resolved
mobile/node.go Outdated Show resolved Hide resolved
mobile/node.go Outdated Show resolved Hide resolved
mobile/node.go Outdated Show resolved Hide resolved
mobile/node.go Show resolved Hide resolved
@drwasho drwasho mentioned this pull request Jul 30, 2019
Closed
@drwasho drwasho added the 🔍 readyForReview Issue or PR ready for code review prior to closing. label Jul 30, 2019
@drwasho drwasho added 🚧 in progress Issue or PR is currently being worked on and not in final form. and removed 🔍 readyForReview Issue or PR ready for code review prior to closing. labels Aug 1, 2019
@cpacia cpacia added 🔍 readyForReview Issue or PR ready for code review prior to closing. and removed 🚧 in progress Issue or PR is currently being worked on and not in final form. labels Aug 5, 2019
@placer14
Merge branch 'master' into mobile-stop
7648f75 
Conflicts:
        mobile/node.go
placer14
placer14 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed merge conflicts in mobile/node.go. @cpacia please take a second to make sure the merge conflicts were resolved properly. If they are, this is GTM.

@cpacia cpacia merged commit 5c18158 into master Aug 8, 2019
@placer14 placer14 mentioned this pull request Sep 12, 2019
Closed
@placer14 placer14 removed the 🔍 readyForReview Issue or PR ready for code review prior to closing. label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@placer14 placer14 placer14 approved these changes

Assignees

@placer14 placer14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpacia @coveralls @placer14 @drwasho